Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solid): Correct deps/devDeps/peerDeps #7682

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix(solid): Correct deps/devDeps/peerDeps #7682

merged 1 commit into from
Jul 6, 2024

Conversation

lachlancollins
Copy link
Member

  • Used manypkg to identify issues with deps/devDeps/peerDeps
  • Mainly identified issues with solid packages (e.g. "solid-js" was installed as a dep rather than a devDep so the peerDep range was not respected)
  • It also corrected alphabetical sorting of packages

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2193f46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TanStack TanStack deleted a comment from vercel bot Jul 6, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 2193f46

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7682

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7682

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7682

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7682

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7682

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7682

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7682

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7682

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7682

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7682

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7682

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7682

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7682

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7682

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7682

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7682

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7682

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7682

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7682

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7682

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7682

templates

@codecov Codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.46%. Comparing base (ea4d8f2) to head (2193f46).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7682   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files         185      185           
  Lines        7049     7049           
  Branches     1550     1548    -2     
=======================================
  Hits         3134     3134           
  Misses       3552     3552           
  Partials      363      363
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query 84.36% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 92.86% <ø> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.98% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 90.00% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.60% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins changed the title fix: Correct deps/devDeps/peerDeps fix(solid): Correct deps/devDeps/peerDeps Jul 6, 2024
@lachlancollins lachlancollins merged commit 9e5bc7b into main Jul 6, 2024
9 checks passed
@lachlancollins lachlancollins deleted the manypkg branch July 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-devtools-experimental package: angular-query-experimental package: solid-query package: solid-query-devtools package: solid-query-persist-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lachlancollins