Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sites feature in django admin for setting site url and name #435

Merged
merged 38 commits into from
Dec 4, 2023

Conversation

braaar
Copy link
Collaborator

@braaar braaar commented Feb 13, 2023

fixes #434

@braaar
Copy link
Collaborator Author

braaar commented Feb 13, 2023

You can see the difference between this and #433 by visiting this link

@braaar braaar changed the title feat: add constance config, use sites in django admin for site configuration feat: add in-app constance settings panel, use only sites in django admin for setting site url and name Feb 13, 2023
@braaar
Copy link
Collaborator Author

braaar commented Mar 19, 2023

@olmari Have you had time to go through this yet? Want me to record a video demo of this feature?

@olmari olmari requested review from tswfi and olmari March 19, 2023 14:57
@olmari
Copy link
Collaborator

olmari commented Mar 19, 2023

Makes it easier (to remember) if review is requested, self-requested now

@braaar
Copy link
Collaborator Author

braaar commented Mar 27, 2023

Corrected some irrelevant formatting changes in banktransaction.html that broke the template code blocks

* constance-config:
  feat: move account IBAN to constance
  fix: remove trailing space
  fix: make for statement single line
  fix: correct whitespace
  fix: additional corrections
  fix: small corrections to template
  fix: undo changes to template code
braaar added 13 commits June 12, 2023 14:04
* constance-config:
  fix: format
  fix: fix imports
  feat: add config accessor
  chore: run black formatter
* constance-config:
  fix: comment
  fix: formatting
  fix: make changes non-breaking
* constance-config:
  fix: revert whitespace change
* constance-config:
  fix: format
  feat: make use of constance for basic things
@tswfi
Copy link
Member

tswfi commented Dec 2, 2023

@braaar can you rebase this?

* main:
  📝 Update release notes
  remove pyup from readme (TampereHacklab#442)
  📝 Update release notes
  remove pyup, using dependabot now (TampereHacklab#440)
  📝 Update release notes
  Small changes to custominvoice texts suggested on tampere channels (TampereHacklab#438)
  📝 Update release notes
  Bump werkzeug from 2.2.2 to 2.2.3 (TampereHacklab#437)
  📝 Update release notes
  Bump django from 4.1.6 to 4.1.7 (TampereHacklab#436)
* main:
  📝 Update release notes
  Always fetch the whole previous year and all of this year so far (TampereHacklab#444)
  📝 Update release notes
  Bump werkzeug from 2.2.3 to 2.3.8 (TampereHacklab#454)
  📝 Update release notes
  Bump pygments from 2.14.0 to 2.15.0 (TampereHacklab#451)
  📝 Update release notes
  feat: add in-app settings panel using django-constance (TampereHacklab#433)
@braaar
Copy link
Collaborator Author

braaar commented Dec 4, 2023

Reverted the formatting on the HTML file now

@braaar braaar changed the title feat: add in-app constance settings panel, use only sites in django admin for setting site url and name fix: use only sites in django admin for setting site url and name Dec 4, 2023
@braaar braaar changed the title fix: use only sites in django admin for setting site url and name fix: use sites feature in django admin for setting site url and name Dec 4, 2023
@tswfi tswfi merged commit f9dd167 into TampereHacklab:master Dec 4, 2023
1 check passed
@tswfi
Copy link
Member

tswfi commented Dec 4, 2023

@braaar thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure site url and site name in one place
3 participants