-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use sites feature in django admin for setting site url and name #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braaar
changed the title
feat: add constance config, use sites in django admin for site configuration
feat: add in-app constance settings panel, use only sites in django admin for setting site url and name
Feb 13, 2023
@olmari Have you had time to go through this yet? Want me to record a video demo of this feature? |
Makes it easier (to remember) if review is requested, self-requested now |
Corrected some irrelevant formatting changes in banktransaction.html that broke the template code blocks |
* constance-config: feat: move account IBAN to constance fix: remove trailing space fix: make for statement single line fix: correct whitespace fix: additional corrections fix: small corrections to template fix: undo changes to template code
tswfi
reviewed
Apr 4, 2023
* constance-config: fix: format fix: fix imports feat: add config accessor chore: run black formatter
* constance-config: fix: comment fix: formatting fix: make changes non-breaking
* constance-config: fix: revert whitespace change
* constance-config: fix: format feat: make use of constance for basic things
@braaar can you rebase this? |
* main: 📝 Update release notes remove pyup from readme (TampereHacklab#442) 📝 Update release notes remove pyup, using dependabot now (TampereHacklab#440) 📝 Update release notes Small changes to custominvoice texts suggested on tampere channels (TampereHacklab#438) 📝 Update release notes Bump werkzeug from 2.2.2 to 2.2.3 (TampereHacklab#437) 📝 Update release notes Bump django from 4.1.6 to 4.1.7 (TampereHacklab#436)
* main: 📝 Update release notes Always fetch the whole previous year and all of this year so far (TampereHacklab#444) 📝 Update release notes Bump werkzeug from 2.2.3 to 2.3.8 (TampereHacklab#454) 📝 Update release notes Bump pygments from 2.14.0 to 2.15.0 (TampereHacklab#451) 📝 Update release notes feat: add in-app settings panel using django-constance (TampereHacklab#433)
tswfi
reviewed
Dec 4, 2023
tswfi
reviewed
Dec 4, 2023
Reverted the formatting on the HTML file now |
braaar
changed the title
feat: add in-app constance settings panel, use only sites in django admin for setting site url and name
fix: use only sites in django admin for setting site url and name
Dec 4, 2023
braaar
changed the title
fix: use only sites in django admin for setting site url and name
fix: use sites feature in django admin for setting site url and name
Dec 4, 2023
@braaar thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #434