Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge chkRip_Type functionality into Crop Settings #4

Closed
Tamk1s opened this issue Jan 6, 2019 · 0 comments
Closed

Merge chkRip_Type functionality into Crop Settings #4

Tamk1s opened this issue Jan 6, 2019 · 0 comments
Assignees
@Tamk1s
Labels
4 - Done enhancement New feature or request

Comments

@Tamk1s
Copy link
Owner

Tamk1s commented Jan 6, 2019 •
edited
Loading

Now that Crop Settings has been refactored with the radio button system:
*Merge "Rip to MP4+Dum" functionality into the new system
*If video has dummy frames and "Dum" radio button is selected, enable a new checkbox. Should read "Don't rip frames" if unchecked, "Rip frames" if checked.
*Only enable chkRip_Type if video has audio.
@Tamk1s Tamk1s self-assigned this Jan 6, 2019
@Tamk1s Tamk1s added 0 - Backlog enhancement New feature or request labels Jan 6, 2019
Tamk1s added a commit that referenced this issue Jan 6, 2019
@Tamk1s
Thwimp v1.1 WIP
6f656ed 
Bugfixes:
*Added -framerate param for THP encoding (to get THPs encoded at proper framerate, fixed Issue #2)

Enhancements:
*Updated application version (v1.1.0.0)
*Made all groupbox headers and lables bold
*Renamed some THP Info lables, to fit with bold font

THP Ripper (fixes Issue #3)
*Refactored Crop Settings for THP Ripping to use an array of radio buttons to select individual subvideo cells to select for ripping, updates the crop settings appropriately. Array also includes 2 special options: "All" and "Dum". "All" rips entire video dimension, "Dum" rips control/dummy section in videos.
*Added multiplicty nud for start/end frame params, and nud to select the multiplicity to rip from (updates start/end frames appropriately). 0=Rip all multiplicities, N=rip Nth mult. A readonly checkbox indicates to the user if a "single" or "all" mults will be ripped
*When clicking the "Rip" button, default filename is updated as appropriately based on the multiplicty and subvideo cell selected, meeting the A1N naming notation for encoding.

TODO before v1.1. release (next commit):
*Fix Issue #4
Tamk1s added a commit that referenced this issue Jan 7, 2019
@Tamk1s
Thwimp v1.1 Code commit
3c50f1a 
Fixed Issue #4:
*Removed "Rip to [format]" checkbox
*Removed dead functions chkRipString(), chkRipValues(), chkRip_Type_CheckedChanged(stuff) event
*Added new chkRipDumF checkbox (set when ripping dummy frames). Conditions to trigger: mult=0, dum radio button set, start/end frames = min/max frames in THP. When chkRipDumF flag is set and those conditions met, ripping will do dummy frames as usual

Bugfixes:
*Fixed a bug where audio file wouldn't be ripped due to the new default filenaming (suffixes)

Enhancements:
*Updated copyright from 2018-2019 for GPL in source code
*Simplified chkRipM_Change function into a simple chkString func call
*Updated readme
@Tamk1s Tamk1s closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tamk1s Tamk1s

Labels
4 - Done enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tamk1s