Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken button and icons are gone. #282

Closed
ghost opened this issue Mar 26, 2024 · 4 comments
Closed

Broken button and icons are gone. #282

ghost opened this issue Mar 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 26, 2024

image
image

@ghost ghost added the bug Something isn't working label Mar 26, 2024
@ghost
Copy link
Author

ghost commented Mar 27, 2024

Version 1.10.3

TakosThings added a commit that referenced this issue Mar 28, 2024
@TakosThings
Copy link
Owner

Krisp icon is a known issue but it's unfixable.

Missing icon fixed in #280

@ghost
Copy link
Author

ghost commented Mar 28, 2024

@TakosThings Why it unfixable? (Just intresting)

@TakosThings
Copy link
Owner

Icon replacements are done by matching the aria-label on buttons, etc. For the Krisp button it looks like this:

    &[aria-label="Noise Suppression powered by Krisp" i]::before{
        content: "\F61F"; // NoiseCancellation
    }

(this is also why the icons only work with English)
For whatever reason the aria-label is removed entirely when the Krisp popout is open. I checked the history of Metro for Discord and it's been an issue for at least 4 years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant