Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New temporal matching/collocation implementation #204

Merged
merged 4 commits into from
Feb 10, 2021

Conversation

s-scherrer
Copy link
Collaborator

This contains a new implementation of temporal matching/collocation, as discussed in #176.

It uses pd.reindex for matching with nearest neighbours, as was done in smecv. I added a method keyword, so different collocation/interpolation methods can be implemented in the future, if necessary.

@s-scherrer
Copy link
Collaborator Author

This is the error in CI:

failed
Pip subprocess error:
ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-install-fd4lpj1t\\ismn_91ccbc45032e405c96f1207e7ea7b342\\tests/test_data/Data_seperate_files_header_20170810_20180809/COSMOS/Barrow-ARM/COSMOS_COSMOS_Barrow-ARM_sm_0.000000_0.210000_Cosmic-ray-Probe_20170810_20180809.stm'
CondaEnvException: Pip failed
Command exited with code 1

Is this related to my changes?

@wpreimes
Copy link
Member

wpreimes commented Dec 15, 2020

This is the error in CI:

failed
Pip subprocess error:
ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-install-fd4lpj1t\\ismn_91ccbc45032e405c96f1207e7ea7b342\\tests/test_data/Data_seperate_files_header_20170810_20180809/COSMOS/Barrow-ARM/COSMOS_COSMOS_Barrow-ARM_sm_0.000000_0.210000_Cosmic-ray-Probe_20170810_20180809.stm'
CondaEnvException: Pip failed
Command exited with code 1

Is this related to my changes?

probably not, as it is also in #205 . Looks more like an issue in the ismn package

@s-scherrer
Copy link
Collaborator Author

'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-install-fd4lpj1t\\ismn_91ccbc45032e405c96f1207e7ea7b342\\tests/test_data/Data_seperate_files_header_20170810_20180809/COSMOS/Barrow-ARM/COSMOS_COSMOS_Barrow-ARM_sm_0.000000_0.210000_Cosmic-ray-Probe_20170810_20180809.stm'

I assume this filename is too long, it's 261 characters, if I remember correctly Windows has a limit of 255 characters.

@wpreimes
Copy link
Member

COSMOS_COSMOS_Barrow-ARM_sm_0.000000_0.210000_Cosmic-ray-Probe_20170810_20180809.stm

yeah, sounds reasonable. Ok so this is nothing related to pytesmo

Copy link
Member

@sebhahn sebhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants