Add/Merge additional params on return urls #1911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the bug where we would redirect to a page with two
?
, breaking the query.To recreate the bug
/Submissions/Catalog/7251?GameId=2356
/Submissions/Catalog/7251?GameId=2356?GameId=2356&GameVersionId=4820
That's the bug, there are two
?
in that final link. Only the first?
counts, so the query setsGameId
to2356?GameId=2356
.After this PR the final link will look like/Submissions/Catalog/7251?GameId=2356&GameId=2356&GameVersionId=4820
.Notice how there are still two
GameId
s, but it works (and query string expliticly allow multiple settings of the same value).After this PR the final link will look like
/Submissions/Catalog/7251?GameId=2356&GameVersionId=4820
.