Prevent select element from flashing right before it's replaced #1782
Conversation
… only way to accommodate noscript users
| @@ -27,6 +27,7 @@ | |||
| <link rel="alternate" href="/publications.rss" type="application/rss+xml" title="TASVideos RSS Publication Feed"> | |||
| <link rel="alternate" href="/wiki.rss" type="application/rss+xml" title="TASVideos RSS Wiki Feed"> | |||
| <partial name="_MetaTags" /> | |||
| <script>document.head.appendChild(document.createElement("style")).innerHTML = '.d-none-js { display: none !important; }';</script> | |||
There was a problem hiding this comment.
Alternatively:
| <script>document.head.appendChild(document.createElement("style")).innerHTML = '.d-none-js { display: none !important; }';</script> | |
| <!-- can move to main stylesheet --><style>:root.supports-js .d-none-js { display: none !important; }</style> | |
| <script>document.documentElement.classList.add("supports-js");</script> |
There was a problem hiding this comment.
(I can't test right now) Have you tested whether that prevents the flashing on repeated reloading on the usual browsers on desktop and mobile?
It may look the same, but I noticed adding a <style> blocks cached rendering better than adding a css class.
There was a problem hiding this comment.
I haven't (I also can't test atm)
There was a problem hiding this comment.
they are all a single taghelper now if that helps with a better strategy. But can we close this? we dont' want this hacky approach
There was a problem hiding this comment.
Yeah I'm going to close this PR. This seems to need a different approach altogether.
|
I'm not sure i want this PR |
|
I'm converting this to a draft, I want to try out the suggested thing and some other stuff. If I can't find anything, I'll just close this. |
|
Closing because we need a different approach altogether. |
Look at this code, this feels very hacky.