Allow MA defaults other than SMA #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjbq7
reviewed
Sep 13, 2022
| @@ -257,7 +257,10 @@ def cleanup(name): | |||
| else: | |||
| print('int %s=-2**31' % var, end=' ') # TA_INTEGER_DEFAULT | |||
| elif arg.startswith('TA_MAType'): | |||
| print('int %s=0' % var, end=' ') # TA_MAType_SMA | |||
| if 'matype' in defaults: | |||
| print('int %s=%s' % (var, defaults['matype']), end=' ') | |||
There was a problem hiding this comment.
We could make this a single line:
print('int %s=%s' % (var, defaults.get('matype', 0)), end=' ')
There was a problem hiding this comment.
I'm not a python developer, so... Could you edit my PR?
There was a problem hiding this comment.
Or you may create a new one from a scratch by yourself - I'll delete this one.
There was a problem hiding this comment.
On a second thougth ...
if 'matype' in defaults:
print('int %s=%s' % (var, defaults['matype']), end=' ')
is not equal to just print('int %s=0' % var, end=' '). Bcs it'll do nothing in case TA_MAType argument exists but have no any default value. Although I think there is no such cases in the sourcecode.
mrjbq7
added a commit
that referenced
this pull request
Sep 13, 2022
Thanks @trufanov-nok, and comments in #544
|
Okay, I made a patch in dae5f6d. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, currently there is no MA indicators in TA-Lib which use optInMAType argument defaults other than SMA(0), but I would like to add a support for such indicators, bcs I was going to add one for myself.
I hardcoded "matype" bcs
default_argcontains "mAType".