use multi-stage build to minimize size of Docker image #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this commit reduce the Docker image size from >1 GB to 205 MB. Docker multi-stage builds were used to achieve this. In the first stage, the core ta-lib library is compiled, and the Python ta-lib package is installed. Then, in the second stage, the compiled core ta-lib library and the Python wheel files are copied over and installed. The second stage also uses the `python:VERSION-slim` Docker image, which is much smaller than the `python:VERSION` image, because it does not include any compilers or other software not necessary at runtime. The build and run procedure is unchanged. Use `docker build --tag ta-lib .` to build and `docker run --rm -it ta-lib bash` to run. Another change introduced by the commit is the option of skipping testing during image building. By default, testing is not skipped, but it can be skipped with `docker uild --tag ts-lib --build-arg RUN_TESTS=0 .`.
mrjbq7
reviewed
Sep 7, 2020
| COPY . . | ||
| RUN python -m pip install -e . \ | ||
| && python -c 'import numpy, talib; close = numpy.random.random(100); output = talib.SMA(close); print(output)' \ |
There was a problem hiding this comment.
The python -m pip install -e . command installs the ta-lib python package. The next line came from the original Dockerfile and is basically a test that the package can be imported and can run talib.SMA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this commit reduce the Docker image size from >1 GB to 205 MB. Docker multi-stage builds were used to achieve this. In the first stage, the core ta-lib library is compiled, and the Python ta-lib package is installed. Then, in the second stage, the compiled core ta-lib library and the Python wheel files are copied over and installed. The second stage also uses the
python:VERSION-slimDocker image, which is much smaller than thepython:VERSIONimage, because it does not include any compilers or other software not necessary at runtime.The build and run procedure is unchanged. Use
docker build --tag ta-lib .to build anddocker run --rm -it ta-lib bashto run.Another change introduced by the commit is the option of skipping testing during image building. By default, testing is not skipped, but it can be skipped with
docker build --tag ts-lib --build-arg RUN_TESTS=0 ..I uploaded a built image to https://hub.docker.com/r/kaczmarj/ta-lib:
docker pull kaczmarj/ta-lib