Refactor InstrumentClipView::adjustVelocity #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored InstrumentClipView::adjustVelocity Added comments to the code, factored out some of the code to separate functions Prep for velocity view
9729a62
to
3a12f54
Compare
m-m-adams
reviewed
Jun 7, 2024
m-m-adams
reviewed
Jun 7, 2024
m-m-adams
approved these changes
Jun 8, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Jun 8, 2024
f2fa8d7
6 checks passed
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* Refactor adjustVelocity Refactored InstrumentClipView::adjustVelocity Added comments to the code, factored out some of the code to separate functions Prep for velocity view * Add more documentation * Address feedback * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored InstrumentClipView::adjustVelocity
Added comments to the code, factored out some of the code to separate functions
Prep for velocity view