Fix scale sidebar column UI inconsistencies #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-m-adams
approved these changes
Jun 3, 2024
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| #include "scale_mode.h" | |||
| #include "gui/ui/keyboard/layout/column_controls.h" | |||
| #include <cstdbool> | |||
There was a problem hiding this comment.
this shouldn't be needed, in cpp it just provides the macro __bool_true_false_are_defined
There was a problem hiding this comment.
Removed!
VSCode keeps adding those automatically..
Merged
via the queue into
SynthstromAudible:community
with commit Jun 3, 2024
0e096f8
6 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Fix scale sidebar column UI inconsistencies * Remove unneeded import
sapphire-arches
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Fix scale sidebar column UI inconsistencies * Remove unneeded import
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* Fix scale sidebar column UI inconsistencies * Remove unneeded import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2066
Fixes #2065
To cherry pick for 1.1