test/refactor: arpgeggiator::midi_cv::Gate values roundtrip #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull out the guts for testing: the current value math is identical to standard, so share the machinery, but the final value computation produces numbers that are slightly smaller near the max values, and needs to remain distinct. They use-provided values roundtrip despite the asymmetry. - Speculate on the reason things are the way they are.
nikodemus
force-pushed
the
arp-midi-cv-gate-value-scaling
branch
from
f7cd69b
to
74a2c1a
Compare
Merged
via the queue into
SynthstromAudible:community
with commit Jun 10, 2024
7474d94
6 checks passed
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…omAudible#2087) - Pull out the guts for testing: the current value math is identical to standard, so share the machinery, but the final value computation produces numbers that are slightly smaller near the max values, and needs to remain distinct. They use-provided values roundtrip despite the asymmetry. - Speculate on the reason things are the way they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out the guts for testing: the current value math is identical to standard, so share the machinery, but the final value computation produces numbers that are slightly smaller near the max values, and needs to remain distinct. They use-provided values roundtrip despite the asymmetry.
Speculate on the reason things are the way they are.