Fix kit shortcut blinks #2073
Merged
Fix kit shortcut blinks #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results39 tests +3 39 ✅ +3 0s ⏱️ ±0s Results for commit 330b784. ± Comparison against base commit 6a8f0c3. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
m-m-adams
reviewed
Jun 3, 2024
m-m-adams
approved these changes
Jun 3, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Jun 3, 2024
be24370
6 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* soundeditor: only use global kit param table when actually setting up global param * soundeditor: Share logic for shortcut blink setup * soundeditor: add missing return in shortcut setup
sapphire-arches
added a commit
that referenced
this pull request
Jun 3, 2024
* soundeditor: only use global kit param table when actually setting up global param * soundeditor: Share logic for shortcut blink setup * soundeditor: add missing return in shortcut setup
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
* soundeditor: only use global kit param table when actually setting up global param * soundeditor: Share logic for shortcut blink setup * soundeditor: add missing return in shortcut setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bonus refactoring that saves some code size as well.