tests: CompParam::readCurrentValue() & getFinalValue() #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull out the guts for testing. - Rename standard menu item roundtrip test to "scaling test", since it tests a few specific values in addition to roundtripping.
nikodemus
force-pushed
the
comp-param-value-scaling
branch
from
12fa111
to
f17dadf
Compare
Test Results36 tests +1 36 ✅ +1 0s ⏱️ ±0s Results for commit f17dadf. ± Comparison against base commit 96a78f8. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
m-m-adams
reviewed
Jun 1, 2024
| auto value = (int64_t)soundEditor.currentParamManager->getUnpatchedParamSet()->getValue(getP()); | ||
| this->setValue((value * (kMaxMenuValue * 2) + 2147483648) >> 32); | ||
| } | ||
| // comp params aren't set up for negative inputs - this is the same as osc pulse width |
There was a problem hiding this comment.
Is this accurate? If so the function should probably be named for unipolar param instead of for comp param
There was a problem hiding this comment.
There's another PR coming that deals with pulse width and does just that :)
There was a problem hiding this comment.
A bunch of the unipolar params do use the full [-1,1) q31 range but are notionally (e.g. volume). HalfPrecisionUnipolar maybe?
There was a problem hiding this comment.
I had InternallyUnipolar previously, but HalfPrecisionUnipolar is better!
m-m-adams
approved these changes
Jun 1, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Jun 2, 2024
d5ab4ee
6 checks passed
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…ible#2068) - Pull out the guts for testing. - Rename standard menu item roundtrip test to "scaling test", since it tests a few specific values in addition to roundtripping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out the guts for testing.
Rename standard menu item roundtrip test to "scaling test", since it tests a few specific values in addition to roundtripping.