-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
voice: use 2x regular release for fast release #2061
voice: use 2x regular release for fast release #2061
Conversation
I'm not sure if this goes against project policy, but I at least would appreciate linking to the song in question. (Maybe also mentioning the reason/uncertainty of this in a comment, so one doesn't need to trawl commit messages to figure out why this is the way it is?) |
yeah, i asked chewabledrapery to file a bug and it looks like they have, which has the song -- this PR is currently underbaked since i just wanted to get something for them to test today. I'll figure out why this works and retarget it to community before marking it ready for review |
bed8157
to
1c41a3c
Compare
Cleaned up the commit message and thought the logic through correctly, should be better now. |
1c41a3c
to
9133c41
Compare
I believe this is actually making fast release at least twice as fast as normal release A release of 0 has an increment of 8192 iirc. A fast release from polyphony limits (mono/auto/legato) is at an increment of 4096, which is doubled by this PR. A soft cull is at an increment of 65536, and so won't be affected Good to merge though since it does seem like a good change |
9133c41
to
217aa7a
Compare
6a8f0c3
This is much more conservative than the original logic, avoiding note-off clicks for soft culls.