refactor: share value scaling between Integer and UnpatchedParam #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Math is exactly the same in both, let's call it compute(Current|Final)ValueForStandardMenuItem. - Add a few tests with explicit values in addition to the roundtripping.
Test Results35 tests ±0 35 ✅ ±0 0s ⏱️ ±0s Results for commit 40e974f. ± Comparison against base commit 3e6a087. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
|
No rush, but FYI: I already have Since this is a largish refactoring, I'm keeping the individual PRs bite sized for easier review, but that does create a bit of a queue... :) |
Merged
via the queue into
SynthstromAudible:community
with commit Jun 1, 2024
96a78f8
6 checks passed
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…thstromAudible#2058) - Math is exactly the same in both, let's call it compute(Current|Final)ValueForStandardMenuItem. - Add a few tests with explicit values in addition to the roundtripping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math is exactly the same in both, let's call it compute(Current|Final)ValueForStandardMenuItem.
Add a few tests with explicit values in addition to the roundtripping.