tests: UnpatchedParam::readCurrentValue() & getFinalValue() #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
nikodemus
force-pushed
the
unpatched-param-value-scaling
branch
from
a7232c2
to
3d4ad67
Compare
- Pull out the guts for testing, refactoring to come. - The inputs have an explicit range, which is short enough that we can enumerate it and check that everything roundtrips.
nikodemus
force-pushed
the
unpatched-param-value-scaling
branch
from
3d4ad67
to
eb33cb2
Compare
|
|
||
| #include <cstdint> | ||
|
|
||
| // Functions that convert parameter values between forms displayed |
There was a problem hiding this comment.
To document the whole file, the doc comment should have triple slash and start with \file value_scaling.h.
Merged
via the queue into
SynthstromAudible:community
with commit May 30, 2024
3e6a087
6 checks passed
nikodemus
added a commit
to nikodemus/DelugeFirmware
that referenced
this pull request
May 31, 2024
…omAudible#2057) * tests: UnpatchedParam::readCurrentValue() & getFinalValue() - Pull out the guts for testing, refactoring to come. - The inputs have an explicit range, which is short enough that we can enumerate it and check that everything roundtrips. * fix file level comment format
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
…omAudible#2057) * tests: UnpatchedParam::readCurrentValue() & getFinalValue() - Pull out the guts for testing, refactoring to come. - The inputs have an explicit range, which is short enough that we can enumerate it and check that everything roundtrips. * fix file level comment format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out the guts for testing, refactoring to come.
The inputs have an explicit range, which is short enough that we can enumerate it and check that everything roundtrips.