More automation view shortcut blinking bug fixes #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some additional shortcut blinking fixes that I pushed to 1.1 that are not yet in community (I had them in my velocity PR). Just extract them here in this PR as further cleanup to make velocity PR easier to review.
seangoodvibes
force-pushed
the
Automation-View-shortcut-blinking-bug-fixes
branch
from
32b8947
to
2da4cc3
Compare
m-m-adams
approved these changes
May 30, 2024
Merged
via the queue into
SynthstromAudible:community
with commit May 30, 2024
1341034
6 checks passed
tastycode
pushed a commit
to tastycode/DelugeFirmware
that referenced
this pull request
Jul 3, 2024
There were some additional shortcut blinking fixes that I pushed to 1.1 that are not yet in community (I had them in my velocity PR). Just extract them here in this PR as further cleanup to make velocity PR easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some additional shortcut blinking fixes that I pushed to 1.1 that are not yet in community (I had them in my velocity PR).
I just extracted them here in this PR as further cleanup to make velocity PR easier to review.
the changes to handleSessionButtonAction and handleClipButtonAction also include some refactoring of the logic in those functions to clean them up.