Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv5 rust version frozen for no-atomic support #6108

Merged
merged 2 commits into from
May 30, 2024

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented May 29, 2024

Description

armv5 rust version frozen for no-atomic support

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 mentioned this pull request May 29, 2024
10 tasks
@th0ma7 th0ma7 requested a review from hgy59 May 30, 2024 00:11
@th0ma7
Copy link
Contributor Author

th0ma7 commented May 30, 2024

@hgy59 would you mind giving this a look? As expected changes where relatively minor for this to work out (or at least seems to be ok at first glance).

@hgy59
Copy link
Contributor

hgy59 commented May 30, 2024

@th0ma7 LGTM, alas the build artifacts are strange. Build 6603 shows 12 Artifacts but only one file for "Packages for aarch64-6.2.4" is available.
Similar result for Build 6602 of sabnzbd: 11 Artifacts but only one file for "Packages for comcerto2k-7.1".
Before, build 6601 was correct (11 artifacts for jellyfin).

spk/python311/Makefile Outdated Show resolved Hide resolved
@th0ma7
Copy link
Contributor Author

th0ma7 commented May 30, 2024

alas the build artifacts are strange. Build 6603 shows 12 Artifacts but only one file for "Packages for aarch64-6.2.4" is available.

Interestingly the aarch64 showed as canceled so I force-run failed builds, which in turn worked out.

Similar result for Build 6602 of sabnzbd: 11 Artifacts but only one file for "Packages for comcerto2k-7.1".

Similar again, build was marked as skipped (not failed) so i forced-run it as well.

Before, build 6601 was correct (11 artifacts for jellyfin).

I would presume it's something else with the github-action that doesn't manage forced-run artifacts correctly whereas older artifacts somehow disapear.

@th0ma7 th0ma7 merged commit 18f68fb into SynoCommunity:master May 30, 2024
1 check passed
@th0ma7 th0ma7 deleted the armv5-rust branch May 30, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants