Framework: add spksrc.main-depends.mk #5881
Conversation
- add mk/spksrc.main-depends.mk to unify Makefile(s) for dependency evaluation - replace spksrc.install-resources.mk by spksrc.main-depends.mk for all such dummy packages - enable make all-supported for such Makefile(s) - remove obsolete PLIST and digests files
|
@th0ma7 can I merge this? I don't know why the build fails to download nasm (for ffmpeg et. al.) since locally I have no problem to download https://fossies.org/linux/misc/nasm-2.16.01.tar.xz. |
There was a problem hiding this comment.
Besides the REAL_CONFIGURE_ARGS that I'm not sure of, LGTM. Overall looks like a neat idea. If I get this right, as the spksrc.main-depends.mk only has pre-check, cross-env and depend it makes the dependency analysis faster?
Side note, I'd rather use another naming than main and main-depends but I have no better option to offer... so perhaps for a later time.
| @$(MSG) - Configure ARGS: $(CONFIGURE_ARGS) | ||
| @$(MSG) - Configure ARGS: $(REAL_CONFIGURE_ARGS) |
There was a problem hiding this comment.
Really? isn't REAL_CONFIGURE_ARGS related to GNU_CONFIGURE only?
There was a problem hiding this comment.
REAL_CONFIGURE_ARGS contains all configure args
with GNU_CONFIGURE = 1, it contains the --host, --build and --prefix args
and it contains the TC_CONFIGURE_ARGS
plus for DSM 7+ it has --localstatedir defined
without GNU_CONFIGURE it is the same as CONFIGURE_ARGS.
EDIT: the default configure target always uses REAL_CONFIGURE_ARGS.
I changed the message to REAL_CONFIGURE_ARGS after I found in cross/gdb-7.12/Makefile there is GNU_CONFIGURE = 1, but finally only CONFIGURE_ARGS are used and the REAL_CONFIGURE_ARGS logic is implemented again.
Is is only confusing with custom configure targets, but this is always the case with a common pre-target message.
Custom configure targets should always add own messages to avoid confusion (when not using REAL_CONDIGURE_ARGS).
My first approach was spksrc.no-op.mk, then spksrc.evaluate-depends.mk and finally spksrc.main-depends.mk based on your naming (*-main) for the PKG_NAME 😄 EDIT: |
I must be getting old... yet another senior moment 👴 |
Description
This framework cleanup is ahead of the next synocli-develop update.
It simplifies the dummy cross modules that are built for dependency evaluation only.
Type of change