Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headphones: update to Python 3.10 #5488

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Nov 13, 2022

Description

update headphones package as current version depends on Python >= 3.7

  • update headphones to Python 3.10
  • update for DSM 7 compatibility

Fixes #5457

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Package update

- update to Python 3.10
- update for DSM 7 compatibility
@hgy59
Copy link
Contributor Author

hgy59 commented Nov 13, 2022

@GuyManning as you are interested in the headphones package, I would kindly ask you, whether you can test this package.

You find the packages created by github build action under "Checks - Build - Summary - Artifacts".

This is the first package for DSM 7 that is an arch independent python package.
use "Packages for noarch-6.0" for DSM 6.x
and "Packages for noarch-7.0" for DSM 7.x

So far I installed on DS-218 (aarch64) with DSM 6.2.4-25556 Update 6 and on DS-218+ (x64) with DSM 7.1.1-42962 Update 2.
On DSM 6 (DS-218) I first installed the current release form the repository (to post the installation logs in #5457) and then updated with the package created by this PR. This even worked after the update in headphones with the internal updater that broke the packge due to missing Python >= 3.7 😄.

As I am not a user of this package, I didn't not test any functionality.

Any feedback would be appreciated.

@GuyManning
Copy link

GuyManning commented Nov 13, 2022 via email

@LevYas
Copy link

LevYas commented Nov 29, 2022

Hi!
Tried this on DS216j DSM 6.2.4-25556 Update 6.
The installation process asked me to install Python 3.1 package (btw, out of curiosity, why not the latest?), I did it, and then installed the Headphones successfully. Headphone's update check said I'm up to date, so looks like the package works great!
Thank you for the update, I think it could be merged.

@hgy59
Copy link
Contributor Author

hgy59 commented Nov 29, 2022

Python 3.1

I hope it asked you for Python 3.10 (this is the latest available as synocommunity package).

Python 3.11 package is still WIP (#5475) and has some issues...

@LevYas
Copy link

LevYas commented Nov 30, 2022

Oh, yes, UR right, I checked the installed packages, and it's 3.10.8-12. Apparently, the package version is not related to the Python version.

@hgy59 hgy59 merged commit 5c56712 into SynoCommunity:master Dec 1, 2022
@hgy59 hgy59 deleted the update_headphones branch December 1, 2022 18:56
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headphones - Failed to Run Package service
3 participants