Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lidarr: avoid downgrade on package updates #5485

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Nov 10, 2022

Description

  • avoid downgrade on package updates
  • remove mono support
  • enable automatic updates by default (on new package installation only)

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

- remove mono dependency
- enable automatic updates
- remove ssl port (the package does not configure ssl and does not create firewall rules for other ports than 8686)
@Safihre
Copy link
Contributor

Safihre commented Nov 11, 2022

@hgy59 can we do followup PR's to update Radarr and Sonarr and enable automatic updates?
Then we resolve most of @bakerboy448 concerns I think.

Copy link

@bakerboy448 bakerboy448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master should be the branch used, not develop.

And only non-defaults should need to be wrote to the config

@mreid-tt
Copy link
Contributor

hey @hgy59, I did a test to confirm that the downgrade does not occur on installation of this update. The methodology was as follows:

  1. Fresh install of package version 20210322-7 from SynoCommunity
  2. Enable TMP folder upgrades using this comment
  3. Update Lidarr to version 1.1.0.2649 using internal updater
  4. Upgrade package using version 20221111-10 from this PR

Once the above was done I was able to confirm that the installed version did not downgrade to Lidarr version 1.0.2.2592 which is included in the package but remained at the higher version.

Some screenshots are included below:
Screenshot 2022-11-14 at 8 42 28 AM
Screenshot 2022-11-14 at 8 42 36 AM

@hgy59 hgy59 merged commit 1b66ba6 into SynoCommunity:master Nov 14, 2022
@hgy59 hgy59 deleted the lidarr_avoid_downgrade branch November 14, 2022 18:50
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants