Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVH update #4686

Merged
merged 12 commits into from
Jun 24, 2021
Merged

TVH update #4686

merged 12 commits into from
Jun 24, 2021

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jun 19, 2021

Motivation: Update DTV tables and to latest git hash
Linked issues: #4680 and #4545 (DSM7 #4524)

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@th0ma7 th0ma7 changed the title Tvh update [WIP] TVH update Jun 19, 2021
@th0ma7 th0ma7 mentioned this pull request Jun 20, 2021
3 tasks
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 20, 2021

@hgy59 with the recent DSM7 wizard changes... I guess I should ensure to circumvent this somehow?

On DSM6 the empty service_preupgrade() was causing:
2021/06/19 06:24:46	upgrade tvheadend 4.3.20210612-27 Begin postuninst
/var/packages/tvheadend/scripts/service-setup: line 70: syntax error near unexpected token `}'
/var/packages/tvheadend/scripts/service-setup: line 70: `}
Removing it solved the issue
@th0ma7 th0ma7 requested a review from ymartin59 June 22, 2021 22:07
@th0ma7 th0ma7 changed the title [WIP] TVH update TVH update Jun 22, 2021
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 22, 2021

Ready for review.
Package build is looking quite good and been performing well for my own personal usage.
Currently available for beta testing through my github.
I intend to bump package version when ready for publishing (along with ffmpeg and others).

Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions

cross/dtv-scan-tables/Makefile Outdated Show resolved Hide resolved
cross/dtv-scan-tables/Makefile Outdated Show resolved Hide resolved
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 24, 2021

two minor suggestions

@hgy59 thnx, applied!

@th0ma7 th0ma7 merged commit 2a5b655 into SynoCommunity:master Jun 24, 2021
@th0ma7 th0ma7 deleted the tvh-update branch June 24, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants