Add clientbuffer module to znc #4602

jaloji · 2021-05-03T17:07:03Z

Motivation: A very usefull module who is still absent in the actual version of ZNC
Linked issues: closes #4279

I saw that the makefile for ZNC compile all the cpp files who are present in module dir so I just have to add the .cpp file for client buffer in /modules dir and add clientbuffer.so in the PLIST file. All compilation are done and .spk packages can be found here: https://github.com/jaloji/spksrc/releases/tag/1.8.2-17

For each new updates of ZNC all the module must be recompiled with the new version.

Checklist

Build rule all-supported completed successfully
New installation of package completed successfully

jaloji · 2021-05-29T22:10:46Z

Need review please.

cross/znc/modules/clientbuffer.cpp

Add information about source code origin in the header

cross/znc/modules/clientbuffer.cpp

- add znc_update_modules target for easy module update - update palaver and push modules - use current clientbuffer module - update SPK_REV and changelog

hgy59 · 2021-06-27T21:52:55Z

@jaloji I have incorporated my proposals and updated two other extra modules.

There was a warning that further znc versions will support cmake only.
I wanted to migrate to cmake, but the build of the extra modules failed (paths ajdusted, but znc-buildmod didn't find python).

We will have to care for this on a future update.

hgy59 · 2021-06-27T21:57:44Z

@jaloji as you are a znc user can you please verify that the clientbuffer and the updated modules (palaver and push) still work?

- push.cpp fails to build for arch-hi3535

- depend on python 3.8 - use DSM 7 compatible var folder

hgy59 · 2021-07-04T20:13:55Z

@jaloji from my point of view this PR is completed now.
Some questions still remain:

the clientbuffer module is installed, but it is not displayed unter Global Modules nor under user's Modules. - is this module working?
under DSM 7 the znc webadmin runs for me only with https and port 8251. With http/8250 I get "connection errors" after login - this might be an issue with firefox (89.0.2) - it works with edge 91.0.864.64, and chrome 91.0.4472.124

jaloji · 2021-07-12T18:27:54Z

@hgy59 Hi thanks a lot for all of your works.
Personally, I still use my version (the one I put here at the start with just the clientbuffer.cpp file in addition to compile) and so far everything works nicely. So I can't say at the moment if yours works. However normally the clientbuffer module is supposed to appear in the list of modules available in webadmin-> Your Settings-> Networks-> Edit it is a checkbox if it is present then the module is recognized if the box is absent then there is a problem. For the second question I do not have DSM 7 at the moment so I will not be able to answer however for https normally it is enough to configure the listening port in SSL for HTTP and IRC in Global Settings.

gawbul · 2021-08-11T19:42:27Z

Can I help test anything at all? Keen to get this working under DSM 7.0 🤞

jaloji · 2021-08-12T00:47:27Z

Can I help test anything at all? Keen to get this working under DSM 7.0 🤞

For me of course you can

gawbul · 2021-08-12T15:44:48Z

Can I help test anything at all? Keen to get this working under DSM 7.0 🤞

For me of course you can

Let me know what you need 👍

gawbul · 2021-08-13T13:55:23Z

Can I help test anything at all? Keen to get this working under DSM 7.0 🤞

For me of course you can

Let me know what you need 👍

Am building locally for DSM 7.0 now, @jaloji @hgy59 🤞
I'll let you know how it goes 👍

hgy59 · 2021-08-13T14:30:16Z

@gawbul you can also download the artifacts built by github action (see Checks)

gawbul · 2021-08-13T15:59:05Z

@gawbul you can also download the artifacts built by github action (see Checks)

Ah, I didn't see that 🤦‍♂️
Thanks, @hgy59 🙏
Would have saved me some time 🙄😂
I'll test now 👍

gawbul · 2021-08-13T18:36:39Z

@hgy59 @jaloji seems to be working for me so far - I'm on the DS120j running DSM 7.0-41890 👍

stephenbond · 2021-08-15T06:45:38Z

Getting same error with upgrade to 1.18.2-17 -

Sun Aug 15 07:40:15 IST 2021
Starting znc command env LD_LIBRARY_PATH=/var/packages/python3/target/lib /volume1/@appstore/znc/bin/znc -d /volume1/@appstore/znc/var
Certificate file exists. Starting...
/volume1/@appstore/znc/bin/znc: error while loading shared libraries: /var/packages/znc/target/lib/libicudata.so.68: internal error

Is there a temporary fix?

hgy59 · 2021-08-15T08:12:00Z

Getting same error with upgrade to 1.18.2-17 -

Sun Aug 15 07:40:15 IST 2021
Starting znc command env LD_LIBRARY_PATH=/var/packages/python3/target/lib /volume1/@appstore/znc/bin/znc -d /volume1/@appstore/znc/var
Certificate file exists. Starting...
/volume1/@appstore/znc/bin/znc: error while loading shared libraries: /var/packages/znc/target/lib/libicudata.so.68: internal error

Is there a temporary fix?

The new package version is 1.18.2-18 (not -17) and the LD_LIBRARY_PATHis /var/packages/python38/target/lib (and not python3).
What spk file do you use and what is your Diskstation Model?

stephenbond · 2021-08-15T08:26:22Z

Hi, I only have option for 1.18.2-17 in my Synology Package Manager

DS215j (MARVELL Armada 375)
DSM 6.2.4-25556

hgy59 · 2021-08-15T10:11:06Z

Hi, I only have option for 1.18.2-17 in my Synology Package Manager

DS215j (MARVELL Armada 375)
DSM 6.2.4-25556

you have to use 1.18.2-18 from this PR (or wait until the update is published and available in SynoCommunity Package Center).

stephenbond · 2021-08-15T12:31:51Z

ah ok, apologies if stupid question but can i donwload the spk for my synology hardware from this PR (i dont see where) or do i have to compile something myself? if its the latter i wouldn't necessarily know how to do this without instructions...

hgy59 · 2021-08-15T12:47:42Z

@stephenbond you could download the github build artifacts in the "checks" section above...

but as this PR is now published, you can download for manual installation from the sc repo page at https://synocommunity.com/package/znc - or wait up to 48 hours, until the new package is visible in the package manager of your diskstation.

stephenbond · 2021-08-15T13:52:34Z

Thanks, i downloaded the spk from synocommunity, unistalled the old version and installed 1.18.2-18.

The python error has gone away (i didnt have Python38 so installed it). Still getting the 'internal error' however:

2021/08/15 14:47:55 start znc 1.8.2-18 Begin start-stop-status start
/volume1/@appstore/znc/bin/znc: error while loading shared libraries: /var/packages/znc/target/lib/libicudata.so.68: internal error
2021/08/15 14:48:17 start znc 1.8.2-18 End start-stop-status start ret=[1]

stephenbond · 2021-08-17T07:06:12Z

@hgy59 Is this an error on my part, or with the package?

stephenbond · 2021-08-20T07:18:15Z

@hgy59 is there a temporary work around for this?

hgy59 · 2021-08-20T16:21:52Z

It looks as libicu library is broken on armv7 archs (I can reproduce the error with DS-115j, armada370 on DSM 6).

stephenbond · 2021-08-21T03:37:49Z

@hgy59 is it fixable, or is it time to upgrade to a newer device :)

hgy59 · 2021-08-22T09:09:47Z

This is reported for Raspi 3 https://sourceforge.net/p/icu/mailman/message/36666855/
Will try the proposals...

hgy59 · 2021-08-22T21:47:14Z

Second proposal seems to work, see #4804.

Just need to add a .cpp files

e3e696c

ymartin59 requested changes Jun 21, 2021

View reviewed changes

cross/znc/modules/clientbuffer.cpp Outdated Show resolved Hide resolved

Update clientbuffer.cpp

7fab267

Add information about source code origin in the header

hgy59 requested changes Jun 27, 2021

View reviewed changes

cross/znc/modules/clientbuffer.cpp Outdated Show resolved Hide resolved

znc: add target to update modules

3507e20

- add znc_update_modules target for easy module update - update palaver and push modules - use current clientbuffer module - update SPK_REV and changelog

hgy59 approved these changes Jun 27, 2021

View reviewed changes

hgy59 added 2 commits July 4, 2021 00:14

exclude unsupported extra module for arch-hi3535

3c47bf7

- push.cpp fails to build for arch-hi3535

update python and make DSM 7 compatible

6717319

- depend on python 3.8 - use DSM 7 compatible var folder

hgy59 mentioned this pull request Jul 5, 2021

Meta: DSM7 package status #4524

Open

hgy59 merged commit f13ff84 into SynoCommunity:master Aug 14, 2021

hgy59 mentioned this pull request Aug 15, 2021

fix package user in privilege file #4781

Merged

3 tasks

hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Aug 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add clientbuffer module to znc #4602

Add clientbuffer module to znc #4602

jaloji commented May 3, 2021 •

edited by hgy59

Loading

jaloji commented May 29, 2021

hgy59 commented Jun 27, 2021

hgy59 commented Jun 27, 2021

hgy59 commented Jul 4, 2021

jaloji commented Jul 12, 2021

gawbul commented Aug 11, 2021

jaloji commented Aug 12, 2021

gawbul commented Aug 12, 2021

gawbul commented Aug 13, 2021

hgy59 commented Aug 13, 2021

gawbul commented Aug 13, 2021 •

edited

Loading

gawbul commented Aug 13, 2021

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021 •

edited

Loading

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021 •

edited

Loading

stephenbond commented Aug 15, 2021

stephenbond commented Aug 17, 2021

stephenbond commented Aug 20, 2021

hgy59 commented Aug 20, 2021

stephenbond commented Aug 21, 2021

hgy59 commented Aug 22, 2021

hgy59 commented Aug 22, 2021

Add clientbuffer module to znc #4602

Add clientbuffer module to znc #4602

Conversation

jaloji commented May 3, 2021 • edited by hgy59 Loading

Checklist

jaloji commented May 29, 2021

hgy59 commented Jun 27, 2021

hgy59 commented Jun 27, 2021

hgy59 commented Jul 4, 2021

jaloji commented Jul 12, 2021

gawbul commented Aug 11, 2021

jaloji commented Aug 12, 2021

gawbul commented Aug 12, 2021

gawbul commented Aug 13, 2021

hgy59 commented Aug 13, 2021

gawbul commented Aug 13, 2021 • edited Loading

gawbul commented Aug 13, 2021

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021 • edited Loading

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021

stephenbond commented Aug 15, 2021

hgy59 commented Aug 15, 2021 • edited Loading

stephenbond commented Aug 15, 2021

stephenbond commented Aug 17, 2021

stephenbond commented Aug 20, 2021

hgy59 commented Aug 20, 2021

stephenbond commented Aug 21, 2021

hgy59 commented Aug 22, 2021

hgy59 commented Aug 22, 2021

jaloji commented May 3, 2021 •

edited by hgy59

Loading

gawbul commented Aug 13, 2021 •

edited

Loading

hgy59 commented Aug 15, 2021 •

edited

Loading

hgy59 commented Aug 15, 2021 •

edited

Loading