Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosquitto last update does NOT start any more if Websockets port is defined #4210

Closed
beardsick opened this issue Oct 7, 2020 · 16 comments
Closed

Comments

@beardsick
Copy link

For new Package Requests, see the guidelines

Setup

Package Name: Mosquitto
Package Version: 1.6.12-10

NAS Model: DS1019+
NAS Architecture: DSM 6.2.3-25426 Update 2
DSM version: DSM 6.2.3-25426 Update 2

After updating my longtime GOOD WORKING previous Mosquitto version (1.4.14-9 ??) to the latest 1.6.12-10 it refused to start and gave an error: "Failed to run the package service"
De-install and re-install with default .conf settings was running fine with this newest version.
However ... when I add an extra listener on port 9001 websockets this latest version refused to start giving the same above message.

=================================================================

Extra listeners

=================================================================

AFTER UPGRADE on 5-10-2020 "Extra listeners" next 2 lines were giving ERROR: "Failed to run the package service" !!! ???

listener 9001
protocol websockets
#=================================================================

Changing the port number to other values than 9001 did not solve the problem.

@BenjV
Copy link

BenjV commented Oct 7, 2020

The port is not the problem, the protocol is the problem
Seems to me that the package is not compiled with websockets and so only support mqtt as protocol

@beardsick
Copy link
Author

Thanks BenjV ... this seems a logical explanation ... but why would SynoCommunity do this for their new version if the previous did have websockets working well ?
How can this be solved ?

@BenjV
Copy link

BenjV commented Oct 7, 2020

Don't no.
Maybe building needs extra or other options and is just the old build process used.

@m7b
Copy link

m7b commented Oct 8, 2020

Hi together,
I have the same problem after upgrading from version 1.4.14-9 to 1.6.12.10 on my DS215j.

The mosquitto.log says:
Error: Websockets support not available.

@BenjV
Copy link

BenjV commented Oct 8, 2020

It seems to be a Mosquitto problem and not a SynoCommunity issue.
see:
eclipse/mosquitto#1740

They say it is fixed, so a new build for this package to upgrade to version 1.6.12 should fix this.

@beardsick
Copy link
Author

Hi all, is there any possibility to download the previous stable version 1.4.14-9 (?) as a .spk file for manual install on the Synology ?
I looked for it but can only find the .spk file for the latest version with the bug inside.

@BenjV
Copy link

BenjV commented Oct 8, 2020

https://synocommunity.com/package/mosquitto

Download the version you want and do a manual install

@arnebjarne
Copy link
Contributor

It seems to be a Mosquitto problem and not a SynoCommunity issue.
see:
eclipse/mosquitto#1740

They say it is fixed, so a new build for this package to upgrade to version 1.6.12 should fix this.

as I read it, it was fixed in 1.6.11...
So this version 1.6.12 must have been compiled without websockets support.

I will try and see if I can compile it myself and see if websockets gets compiled in by default or not.

@BenjV
Copy link

BenjV commented Oct 10, 2020

Maybe you should read the whole thread before posting already posted information.

@arnebjarne
Copy link
Contributor

Maybe you should read the whole thread before posting already posted information.

lol my bad. Anyway trying to rebuild the package myself right now to see if I can fix the problem.

hgy59 added a commit to ymartin59/spksrc that referenced this issue Oct 10, 2020
@hgy59 hgy59 mentioned this issue Oct 10, 2020
3 tasks
@hgy59
Copy link
Contributor

hgy59 commented Oct 10, 2020

Anyway trying to rebuild the package myself right now to see if I can fix the problem.

@arnebjarne can you confirm this is fixed with my latest commit?

@arnebjarne
Copy link
Contributor

Anyway trying to rebuild the package myself right now to see if I can fix the problem.

@arnebjarne can you confirm this is fixed with my latest commit?

Hi hgy59.

I think i still miss some of you patches
libwebsockets 3.2.2 fails compiling due to the openssl issue
Compiling with SSL support
CMake Error at /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY) (found
version "1.1.1d")

I will double check your big commit from mosquotto 1.4 to 1.6.12
(nb: I am compiling for DS418 with "make arch-rtd1296)

I get back.

@arnebjarne
Copy link
Contributor

Anyway trying to rebuild the package myself right now to see if I can fix the problem.

@arnebjarne can you confirm this is fixed with my latest commit?

Hi hgy59.

I can confirm that your latest commit ( https://github.com/ymartin59/spksrc/tree/4044_update_mosquitto ) make mosquitto 1.6.12-10 compile with websockets on arch-rtd1296.
( I was missing your openssl fix - cbda607).

I have the version running on my DS418.

hgy59 added a commit that referenced this issue Oct 10, 2020
* mosquitto: update to 1.6.12
* fix configure options (similar to #4196)
* changes not already commited on #4068
- updated libwebsockets
- fix clock_gettime for arm5 and older ppc
- install mosquitto_rr too
- update icon
* use current config file
* support ppc853x by patch
* Fix openssl install for CMake to detect it
* fix make options #4210
* final fix for openssl 1.0.1
- remove openssl.cnf from PLIST as it was removed by using installed /etc/ssl/openssl.cnf

Co-authored-by: hgy59 <[email protected]>
@beardsick
Copy link
Author

@BenjV , thanks for the link to the downloads of old versions.
I tried them but they seem for Synology DSM 6.1 and I have DSM 6.2.3-25426 Update 2 ... I got an error.
Am I doing something wrong ?

@BenjV
Copy link

BenjV commented Oct 11, 2020

There is no difference for DSM 6.1 and DSM 6.2 packages, they are all compatible.

But the package is already upgraded to 1.6.12-10 so manual download is not needed anymore.

@ymartin59
Copy link
Contributor

Update 1.6.12-11 published and tested with protocol websockets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants