Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple translation used in emails from shopBundle to coreBundle #12405

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Decouple translation used in emails from shopBundle to coreBundle #12405

merged 1 commit into from
Mar 5, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Mar 2, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@arti0090 arti0090 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). API APIs related issues and PRs. labels Mar 2, 2021
@arti0090 arti0090 requested a review from a team as a code owner March 2, 2021 12:53
@arti0090 arti0090 force-pushed the decouple-email-translations branch from ee63630 to 23086f1 Compare March 4, 2021 07:22
pamil
pamil approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It highly relies on the bundle loading order though.

@lchrusciel lchrusciel merged commit 6bbd6ed into Sylius:master Mar 5, 2021
@lchrusciel
Copy link
Member

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arti0090 @lchrusciel @pamil @AdamKasp