Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge insets extensions #500

Merged
merged 5 commits into from
Jun 15, 2018
Merged

Edge insets extensions #500

merged 5 commits into from
Jun 15, 2018

Conversation

LucianoPAlmeida
Copy link
Member

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Jun 15, 2018

4 Messages
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖 Executed 475 tests, with 0 failures (0 unexpected) in 3.312 (3.825) seconds
📖 Executed 444 tests, with 0 failures (0 unexpected) in 1.625 (2.004) seconds
📖 Executed 329 tests, with 0 failures (0 unexpected) in 1.290 (1.532) seconds

Generated by 🚫 Danger

@LucianoPAlmeida
Copy link
Member Author

Hey @omaralbeik Is this the behavior expected from #475?
Implementing this one so we can prepare for the next release. I thought will be cool to have those on it :))
cc @SD10

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #500 into master will decrease coverage by 0.07%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   91.77%   91.69%   -0.08%     
==========================================
  Files          63       64       +1     
  Lines        2747     2757      +10     
==========================================
+ Hits         2521     2528       +7     
- Misses        226      229       +3
Flag Coverage Δ
#ios 91.69% <70%> (-0.08%) ⬇️
#osx 86.54% <70%> (-0.07%) ⬇️
#tvos 86.54% <70%> (-0.07%) ⬇️
Impacted Files Coverage Δ
...rces/Extensions/UIKit/UIEdgeInsetsExtensions.swift 70% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c2f22...c080244. Read the comment docs.

SD10
SD10 previously approved these changes Jun 15, 2018
Copy link
Member

@SD10 SD10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

be-meyer
be-meyer previously approved these changes Jun 15, 2018
Copy link
Member

@be-meyer be-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@omaralbeik omaralbeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @LucianoPAlmeida 💯
I think it makes more sense to move the source urls into the function body, so the credits appear when users are looking at the implementation, but not in the docs in Xcode menus.

@LucianoPAlmeida
Copy link
Member Author

Sure @omaralbeik :))

@LucianoPAlmeida LucianoPAlmeida dismissed stale reviews from be-meyer and SD10 via c080244 June 15, 2018 12:50
Copy link
Member

@omaralbeik omaralbeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LucianoPAlmeida

@SD10 SD10 merged commit 592f838 into master Jun 15, 2018
@SD10 SD10 deleted the edge-insets-extensions branch June 15, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants