Update Add_New_Content.kt #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solved the bug of save button click, while clicking the button without adding content no snackbar appearing to notify user about empty content.
|
@Suryansh1720001 this issue seems duplicate, and solved in a lot of PRs, please take a look. |
|
Any update on this?
…On Mon, 26 Jun, 2023, 5:42 pm Vaibhav Jaiswal, ***@***.***> wrote:
@Suryansh1720001 <https://github.com/Suryansh1720001> this issue seems
duplicate, and solved in a lot of PRs, please take a look.
—
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5A3PUZ4SNGZTACPUO377DXNF4CVANCNFSM6AAAAAAZTGCW4U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Chayandev |
|
Ok !
…On Thu, 29 Jun, 2023, 3:51 pm Suryansh Prajapati, ***@***.***> wrote:
@Chayandev <https://github.com/Chayandev>
Actually, this issue has already been assigned to someone else. I have
asked him to handle the specific updates. If he is unable to update the
functionality, then we will consider your pull request (PR).
—
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5A3PWQJMKRT6OESB5SCI3XNVJJ5ANCNFSM6AAAAAAZTGCW4U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved the bug of save button click, while clicking the button without adding content no snackbar appearing to notify user about empty content.
Fixes Issue #94
Changes proposed
There was an issue in the contional cheking , which is fixed in this updated Add_New_Content.kt
if (!PoemDes?.html!!.isNullOrEmpty()) is replaced by if (!PoemDes?.html.isNullOrEmpty())
Check List (Check all the applicable boxes)
Screenshots
Demo video
video_2023-06-25_20-07-18.mp4
Note to reviewers