Rule: var-shadows-builtin
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
var-shadows-builtin
branch
from
0f7c093
to
486d1e9
Compare
charlieegan3
approved these changes
Jul 2, 2024
Also in this PR is a slight change of behavior, where variables found in comprehension heads are no longer treated as assigned. This as they _aren't_, and the assignment happens in the comprehension body (or outside the comprehension). This change will uncover a few more `use-some-for-output-vars` issues in policy, which was also fixed as part of this PR. Fixes #823 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
var-shadows-builtin
branch
from
486d1e9
to
2a76aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also in this PR is a slight change of behavior, where variables found in comprehension heads are no longer treated as assigned. This as they aren't, and the assignment happens in the comprehension body (or outside the comprehension). This change will uncover a few more
use-some-for-output-varsissues in policy, which was also fixed as part of this PR.Fixes #823