Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single file impossible-not #713

Merged
merged 1 commit into from
May 13, 2024
Merged

Single file impossible-not #713

merged 1 commit into from
May 13, 2024

Conversation

anderseknert
Copy link
Member

Improve this new rule to have the report rule handle single file violations, while the aggregate report ignores violations where the not ref and the partial rule is in the same file.

Improve this new rule to have the `report` rule handle single file violations,
while the aggregate report ignores violations where the `not` ref and the partial
rule is in the same file.

Signed-off-by: Anders Eknert <[email protected]>
@srenatus srenatus changed the title Singe file impossible-not Single file impossible-not May 13, 2024
@anderseknert anderseknert linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@anderseknert anderseknert merged commit e225bda into main May 13, 2024
3 checks passed
@anderseknert anderseknert deleted the single-file-impossible-not branch May 13, 2024 12:54
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
Improve this new rule to have the `report` rule handle single file violations,
while the aggregate report ignores violations where the `not` ref and the partial
rule is in the same file.

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rule: add single file version of impossible-not rule
2 participants