lsp: Load config from parent dirs #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #626 Signed-off-by: Charlie Egan <[email protected]>
|
Huh, there seems to be something wrong with a flake. I'll need to look into that next week 😞 |
anderseknert
approved these changes
Apr 15, 2024
charlieegan3
force-pushed
the
load-config-from-parent
branch
from
2f95077
to
e79391b
Compare
charlieegan3
force-pushed
the
load-config-from-parent
branch
from
dffade6
to
b46aeb8
Compare
Signed-off-by: Charlie Egan <[email protected]>
Server tests refactored a little to allow messages to be sent in a different order. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
load-config-from-parent
branch
from
b46aeb8
to
76c20ed
Compare
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
|
I have made some adjustments to the server tests again to make them more robust to the order of messages. Feel free to take another look if you'd like or otherwise I think we can merge. |
|
@charlieegan3 good to merge! Just this question:
But if this solves the problem as reported, I think that could be a future improvement if requested. |
|
I'll get back to the reporter and see if they can confirm 😊 |
This was referenced Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #626
Screen.Recording.2024-04-11.at.18.36.52.mov