Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Cleinman committed May 26, 2021
1 parent da00db9 commit cf5dd6b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ platform :ios do
)
end

desc "Add a release tag for the latest beta and push to repo."
desc "Add a build tag for the current build number and push to repo. While this tags a build, tag_release sets a release tag."
lane :tag do |options|
prefix = options[:prefix] || "betas"
build_number = options[:build_number] || options[:build] || get_build_number
Expand All @@ -189,7 +189,7 @@ platform :ios do
sh "git push origin --tags"
end

desc "Add a release tag for the latest beta and push to repo."
desc "Add a release tag for the latest beta and push to repo. For tagging non-releases, use `tag`."
lane :tag_release do |options|
specified_build = options[:build_tag]
if specified_build.nil? || specified_build.empty?
Expand Down Expand Up @@ -287,7 +287,7 @@ platform :ios do

lane :get_recent_commits do |options|
start = options[:start] || "HEAD"
`git log #{start}..HEAD --merges --first-parent main --pretty=format:"%h - %s" | sed 's/Merge pull request \#/https:\\/\\/github.com\\/wikimedia\\/wikipedia-ios\\/pull\\//g'`
`git log betas/1808..HEAD --merges --first-parent main --pretty=format:"%h - %b (%s)" | sed 's/Merge pull request //g'`
end

desc "updates version, builds, and pushes to TestFlight"
Expand Down
4 changes: 2 additions & 2 deletions fastlane/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ Increment the app version major
```
fastlane ios tag
```
Add a release tag for the latest beta and push to repo.
Add a build tag for the current build number and push to repo. While this tags a build, tag_release sets a release tag.
### ios tag_release
```
fastlane ios tag_release
```
Add a release tag for the latest beta and push to repo.
Add a release tag for the latest beta and push to repo. For tagging non-releases, use `tag`.
### ios build
```
fastlane ios build
Expand Down

0 comments on commit cf5dd6b

Please sign in to comment.