minor details

StigNygaard · Oct 1, 2023 · e762095 · e762095
1 parent 191f457
commit e762095
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/WebExtension/contentscript.js b/WebExtension/contentscript.js
@@ -495,6 +495,12 @@
 
  function imageSearch(request, elem) {
  // TODO: Look if elem has a shadowDOM beneath it?
+ // https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/dom/openOrClosedShadowRoot
+ // element.openOrClosedShadowRoot - The Element.openOrClosedShadowRoot read-only property represents the shadow root hosted by the element, regardless if its mode is open or closed (WebExtensions only - Firefox only)
+ // -> Combined: let shadowRoot = chrome.dom?.openOrClosedShadowRoot(element) || element.openOrClosedShadowRoot();
+ // BUT if just looking for *open* shadowRoots:
+ // element.shadowRoot
+
  context.debug("imageSearch(): Looking for img elements on/below " + elem.nodeName.toLowerCase());
 
  let candidate;

diff --git a/WebExtension/popup/popup.js b/WebExtension/popup/popup.js
@@ -308,7 +308,7 @@ function populate(response) {
  }
 
  const orderedKeys = ["Headline", "Caption", "ObjectName", "Date", "Creditline", "Copyright", "UsageTerms", "LicenseURL",
- "Creator", "CreatorAddress", "CreatorCity", "CreatorRegion", "CreatorPostalCode", "CreatorCountry", "CreatorPhoneNumbers", "CreatorEmails", "CreatorURLs",
+ "Creator", "CreatorAddress", "CreatorCity", "CreatorRegion", "CreatorPostalCode", "CreatorCountry", "CreatorPhoneNumbers", "CreatorEmails", "CreatorURLs", "DigitalSourceType",
  "Make", "Model", "Lens", "FocalLengthText", "DigitalZoomRatio", "ApertureFNumber", "ExposureTime", "ISOequivalent", "FlashUsed", "WhiteBalance", "Distance",
  "GPSLat", "GPSLon", "GPSAlt", "GPSImgDir", "CountryName", "ProvinceState", "City", "Sublocation" ];
  const foundKeys = Object.keys(response.data);