Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateHostsFile.py: use a raw string for comment #2621

Merged
merged 1 commit into from
Apr 4, 2024
Merged

updateHostsFile.py: use a raw string for comment #2621

merged 1 commit into from
Apr 4, 2024

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 3, 2024

This fixes a SyntaxWarning with Python 3.12:

 /home/runner/work/hosts/hosts/updateHostsFile.py:1386: SyntaxWarning: invalid escape sequence '\W'
  """

This fixes a SyntaxWarning with Python 3.12:

```
 /home/runner/work/hosts/hosts/updateHostsFile.py:1386: SyntaxWarning: invalid escape sequence '\W'
  """
```
@XhmikosR XhmikosR marked this pull request as ready for review April 3, 2024 05:21
@funilrys
Copy link
Contributor

funilrys commented Apr 3, 2024

I can't image this is the solution ... Why not just do escape the Windows path ? Anyone who look at the source code, will understand...

A RAW docstring might mislead developers with less experience ...

#JustMy2Cents 😄

Stay safe and healthy!

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 3, 2024

Because it's less changes 😊

@StevenBlack
Copy link
Owner

Thank you @XhmikosR and thank you Nissar @funilrys for the assist.

@StevenBlack StevenBlack merged commit bcc0ff4 into StevenBlack:master Apr 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants