fix: extract constructor parameters & generic type info form derived attributes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveDunn
reviewed
Jan 22, 2023
SteveDunn
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue introduced in #321 (reported by @glen-84 in comments) where derived attributes failed to extract parameters/generic types. This was caused by the configuration builder getting generic type arguments from the attribute class without also looking at the base class - as well as my own lack of understand on how Vogen extracted data from attributes (e.g. conversions).
As part of this fix I've also modified the test that produced a false positive to cover both non-
inttypes and custom parameters. TheREADMEhas also been updated to highlight that constructors of derived attributes need to have the defaults in their constructor, not the base constructor.