Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check both default namespace and NsXQueryFunc when binding functions #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

binarycow
Copy link
Contributor

If a document has the default namespace set, FunctionTable.Bind will use that namespace to resolve a function name.

This change will use the default NsXQueryFunc namespace URI if a function does not exist for the user specified namespace URI.

@StefH
Copy link
Owner

StefH commented Sep 16, 2020

@binarycow The unit test fail, can you please check?

And also run the https://github.com/StefH/XPath2.Net/tree/master/src/XQTSRun tool to check if the same coverage in % is as before.

@binarycow
Copy link
Contributor Author

The unit tests in VS all pass. The XQTSRun tool needs a file? Where do I get that file?

@StefH
Copy link
Owner

StefH commented Sep 16, 2020

  1. The unit tests on build server fail.
  2. https://github.com/StefH/XPath2.Net#info has info on how to get the set

@StefH
Copy link
Owner

StefH commented Jun 21, 2021

@binarycow
Can you merge latest master from my project into your branch ? I did fix some CI build things.

@binarycow binarycow force-pushed the alternate-namespace-for-function branch from 6de400e to 046ffcb Compare July 4, 2021 18:55
@binarycow
Copy link
Contributor Author

@StefH - rebased

@StefH
Copy link
Owner

StefH commented Jul 5, 2021

@binarycow
Thanks.

Can you once verify if all tests pass?
""conforms for 12954 from 15133""

@StefH
Copy link
Owner

StefH commented Jul 12, 2021

@binarycow
Thanks.

Did you have time to verify if all tests pass?
""conforms for 12954 from 15133""

@StefH
Copy link
Owner

StefH commented Aug 19, 2021

@binarycow
I did merge latest master into your branch.
And now all the tests from the test suite are also run as a unit test.

And with this change, the test K-SeqExprCast-1422 fails.

Can you investigate ?

@StefH
Copy link
Owner

StefH commented Nov 28, 2022

@binarycow
Did you have time to check why test K-SeqExprCast-1422 fails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants