Added support for decoding OpenSSL RSA public keys in PEM format. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
Mar 1, 2018
examples/ConsoleAppNetCore/Demo.cs
Outdated
| } | ||
| } | ||
|
|
||
| private static bool CompareByteArrays(byte[] arrayA, byte[] arrayB) |
There was a problem hiding this comment.
You can use https://msdn.microsoft.com/en-us/library/bb348567.aspx for this.
| internal static class DecoderUtils | ||
| { | ||
| internal static bool CompareByteArrays(byte[] arrayA, byte[] arrayB) | ||
| { |
There was a problem hiding this comment.
Replace content from this method by https://msdn.microsoft.com/en-us/library/bb348567.aspx if possible.
There was a problem hiding this comment.
We can't do this because the library supports .Net Framework 2.0 and Linq is not supported.
|
|
||
| internal static byte[] ExtractBytes(string text, string header, string footer) | ||
| { | ||
| var data = text; |
|
|
||
| internal static int GetFieldLength(BinaryReader reader) | ||
| { | ||
| var bt = reader.ReadByte(); |
| var bytesToRead = bt & 0x0F; | ||
| var lengthArray = new byte[4]; | ||
|
|
||
| for (var i = 4 - bytesToRead; i < 4; i++) |
| using (var reader = new BinaryReader(memoryStream)) | ||
| { | ||
| var dataType = reader.ReadByte(); | ||
| var fieldLength = DecoderUtils.GetFieldLength(reader); |
| return default(RSAParameters); | ||
| } | ||
|
|
||
| var bt = reader.ReadByte(); |
| return default(RSAParameters); | ||
| } | ||
|
|
||
| var bitStreamLength = DecoderUtils.GetFieldLength(reader); |
| return default(RSAParameters); | ||
| } | ||
|
|
||
| var dateType = reader.ReadByte(); |
| return default(RSAParameters); | ||
| } | ||
|
|
||
| var sequenceLength = DecoderUtils.GetFieldLength(reader); |
|
Thanks a lot for this PR, I've added some comments, can you take a look? |
|
what's the reason against using var parameters on variables? |
|
Normally, I use only |
StefH
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for loading OpenSSL RSA public keys in PEM format.
You can generate the public key with OpenSSL using:
openssl rsa -in private.key -out public.key -puboutI also bumped up the version number, so it is ready to publish a nuget package.