Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if filecontent in js is a string for base64 decoding #7

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Check if filecontent in js is a string for base64 decoding #7

merged 1 commit into from
Dec 10, 2021

Conversation

BuzzDee3000
Copy link
Contributor

Blazor has a breaking change in .net6 and does not convert the byte array into base64 anymore.
https://docs.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/6.0/byte-array-interop

This change checks the submitted type of the content parameter in javascript. In .net below version 6 the injected base64 string will be decoded.

@StefH StefH added the bug Something isn't working label Dec 10, 2021
@StefH
Copy link
Owner

StefH commented Dec 10, 2021

@BuzzDee3000
Thank you for this PR.

@StefH StefH merged commit 5ba2b31 into StefH:main Dec 10, 2021
@BuzzDee3000
Copy link
Contributor Author

@StefH
Thank you for accepting the PR.
It would be cool if you can trigger a release in time.
This bug is blocking the upgrade process to .net6 for my projects.

@StefH
Copy link
Owner

StefH commented Dec 10, 2021

@BuzzDee3000
A new release will be published in some time. (< 1 hour)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants