Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to prettier 3.0.0 #318

Merged
merged 12 commits into from
Jul 13, 2023
Merged

feat: migrate to prettier 3.0.0 #318

merged 12 commits into from
Jul 13, 2023

Conversation

tlakomy
Copy link
Contributor

@tlakomy tlakomy commented Jul 12, 2023

No description provided.

@tlakomy tlakomy mentioned this pull request Jul 12, 2023
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:jest/recommended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we removed jest plugin. Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See jest-community/eslint-plugin-jest#1398 for reference. We're not actively adding unit tests for this package so I concluded that it's not worth the investment right now. I'd also rather not use --force nor --legacy-peer-deps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very valuable context. Thank you.

@tlakomy tlakomy merged commit d906616 into main Jul 13, 2023
7 checks passed
@tlakomy tlakomy deleted the migrate-to-prettier-3.0.0 branch July 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants