Remove only_public from pics requests #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakov-h
reviewed
Aug 28, 2020
| /// <param name="metaDataOnly">Whether to send only meta data.</param> | ||
| /// <returns>The Job ID of the request. This can be used to find the appropriate <see cref="PICSProductInfoCallback"/>.</returns> | ||
| public AsyncJobMultiple<PICSProductInfoCallback> PICSGetProductInfo(uint? app, uint? package, bool onlyPublic = true, bool metaDataOnly = false) |
There was a problem hiding this comment.
This is a source-breaking change for any calls like PICSGetProductInfo(1, 2, true).
There was a problem hiding this comment.
I never liked these bools, as overload that takes IEnumerable<PICSRequest did not have onlyPublic already.
| /// <param name="metaDataOnly">Whether to send only meta data.</param> | ||
| /// <returns>The Job ID of the request. This can be used to find the appropriate <see cref="PICSProductInfoCallback"/>.</returns> | ||
| public AsyncJobMultiple<PICSProductInfoCallback> PICSGetProductInfo( IEnumerable<uint> apps, IEnumerable<uint> packages, bool onlyPublic = true, bool metaDataOnly = false ) | ||
| public AsyncJobMultiple<PICSProductInfoCallback> PICSGetProductInfo( IEnumerable<uint> apps, IEnumerable<uint> packages, bool metaDataOnly = false ) |
yaakov-h
reviewed
Aug 29, 2020
| @@ -263,7 +239,7 @@ public AsyncJobMultiple<PICSProductInfoCallback> PICSGetProductInfo( IEnumerable | |||
| var appinfo = new CMsgClientPICSProductInfoRequest.AppInfo(); | |||
| appinfo.access_token = app_request.AccessToken; | |||
| appinfo.appid = app_request.ID; | |||
| appinfo.only_public_obsolete = app_request.Public; | |||
| appinfo.only_public_obsolete = false; | |||
There was a problem hiding this comment.
can we just omit it entirely here?
There was a problem hiding this comment.
We can, but I don't know what Valve defaults to on the backend, if at all (since it doesn't seem to have an effect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #910
It was renamed to
only_public_obsoletein protos, and I believe it has no effect.Question: Is it a good idea to make
PICSRequesta struct?