Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exceptions serializable, have standard constructors #1395

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Make exceptions serializable, have standard constructors #1395

merged 1 commit into from
Aug 5, 2024

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Aug 2, 2024

Fixes #1207

@xPaw xPaw added this to the 3.0.0 milestone Aug 2, 2024
@xPaw xPaw marked this pull request as ready for review August 2, 2024 19:19
@yaakov-h
Copy link
Member

yaakov-h commented Aug 5, 2024

I don't think we need the serializable attribute anymore.

dotnet/docs#34893

@xPaw
Copy link
Member Author

xPaw commented Aug 5, 2024

What about the constructors?

@yaakov-h
Copy link
Member

yaakov-h commented Aug 5, 2024

Additional constructors are still good.

@xPaw xPaw merged commit 8c75700 into master Aug 5, 2024
15 checks passed
@xPaw xPaw deleted the xpaw/exceptions branch August 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Exceptions should be serializable, have standard constructors
2 participants
@xPaw @yaakov-h