Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prefix/suffix options for boolean, number and string widgets #888

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

KaneFreeman
Copy link
Collaborator

@KaneFreeman KaneFreeman commented Sep 19, 2023

Inspired by decaporg/decap-cms#6836

Resolves #887

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit 8a87e44
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/6509f28bdeadff0008426b8d
😎 Deploy Preview https://deploy-preview-888.demo.staticcms.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit 8a87e44
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/6509f28ba0d81b0008c83145
😎 Deploy Preview https://deploy-preview-888.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KaneFreeman KaneFreeman linked an issue Sep 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #888 (8a87e44) into next (4a908d5) will increase coverage by 0.11%.
Report is 1 commits behind head on next.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next     #888      +/-   ##
==========================================
+ Coverage   52.30%   52.42%   +0.11%     
==========================================
  Files         232      232              
  Lines        9917     9942      +25     
  Branches     2593     2612      +19     
==========================================
+ Hits         5187     5212      +25     
  Misses       4347     4347              
  Partials      383      383              
Files Changed Coverage Δ
...ckages/core/src/widgets/boolean/BooleanControl.tsx 100.00% <100.00%> (ø)
packages/core/src/widgets/number/NumberControl.tsx 97.82% <100.00%> (+0.45%) ⬆️
packages/core/src/widgets/string/StringControl.tsx 100.00% <100.00%> (ø)
packages/core/src/widgets/text/TextControl.tsx 100.00% <100.00%> (ø)
packages/core/test/data/fields.mock.ts 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@KaneFreeman KaneFreeman merged commit 22ff427 into next Sep 19, 2023
19 checks passed
@KaneFreeman KaneFreeman deleted the feat/prefix-suffix branch September 19, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix/suffix options for boolean, string and number widgets
1 participant