Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support list partition for backup restore #51993

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[Enhancement] Support list partition for backup restore #51993

merged 1 commit into from
Oct 17, 2024
+278 −11

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Oct 16, 2024 •
edited
Loading

Why I'm doing:

List partition is not supported in backup restore.

What I'm doing:

Support list partition for backup restore.
Some code will be refactored in next pr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg xiangguangyxg requested a review from a team as a code owner October 16, 2024 11:07
@xiangguangyxg xiangguangyxg requested a review from a team as a code owner October 17, 2024 03:14
@xiangguangyxg xiangguangyxg changed the title [Enhancement] Support list partition for restore [Enhancement] Support list partition for backup restore Oct 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 33 / 40 (82.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/OlapTable.java 33 40 82.50% [906, 907, 915, 920, 921, 922, 965]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit d62055e into StarRocks:main Oct 17, 2024
62 of 63 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.3 label Oct 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@xiangguangyxg @mergify
[Enhancement] Support list partition for backup restore (#51993)
5aaf4e1 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit d62055e)
@mergify mergify bot mentioned this pull request Oct 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@xiangguangyxg @mergify
[Enhancement] Support list partition for backup restore (#51993)
8f63d82 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit d62055e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
@mergify mergify bot mentioned this pull request Oct 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
@xiangguangyxg @mergify
[Enhancement] Support list partition for backup restore (#51993)
fa58982 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit d62055e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/BackupRestoreAnalyzer.java
#	fe/fe-core/src/test/java/com/starrocks/backup/CatalogMocker.java
@mergify mergify bot mentioned this pull request Oct 17, 2024
Merged
42 tasks
dirtysalt pushed a commit to dirtysalt/starrocks that referenced this pull request Oct 18, 2024
@xiangguangyxg @dirtysalt
[Enhancement] Support list partition for backup restore (StarRocks#51993
ecb7bec 
)

Signed-off-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Enhancement] Support list partition for backup restore (backport #51993
6560277 
) (#52041)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Enhancement] Support list partition for backup restore (backport #51993
2e41430 
) (#52040)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Enhancement] Support list partition for backup restore (backport #51993
48c16ec 
) (#52039)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg deleted the backup_list_partition branch October 18, 2024 01:59
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@xiangguangyxg @ZiheLiu
[Enhancement] Support list partition for backup restore (StarRocks#51993
13509b7 
)

Signed-off-by: xiangguangyxg <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@xiangguangyxg @renzhimin7
[Enhancement] Support list partition for backup restore (StarRocks#51993
1de78cb 
)

Signed-off-by: xiangguangyxg <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@gengjun-git gengjun-git gengjun-git approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiangguangyxg @kevincai @kangkaisen @gengjun-git