Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add jemalloc memory tracker #51382

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Sep 25, 2024

Why I'm doing:

Jemalloc metadata is a footprint of jemalloc, which cannot be used by starrocks process. It should be considered into the ProcessMemTracker, otherwise the memory usage would exceed the specified mem_limit. For some edge cases, it can exceed 10GB, which is significant.

And also, there would be some fragmentation in jemalloc, which means not all of memory can be used for allocation, we need to consider them into the MemTracker.

What I'm doing:

  1. Add a jemalloc_metadata MemTracker and update according to stats.metadata from jemalloc
  2. Add a jemalloc_fragmentation MemTracker and set it to 0.3 * (rss-allocated-metadata)
  3. Add a new configuration in be: jemalloc_fragmentation_ratio, whose default value is 0.3
  4. Put them into the ProcessMemTracker to reserve some memory

Function configurations:

  • enable_jemalloc_memory_tracker, whether enable this feature, default true
  • jemalloc_fragmentation_ratio, the supposed fragmentation ratio of jemalloc

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

satanson
satanson previously approved these changes Sep 25, 2024
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 51 / 51 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/exec_env.h 2 2 100.00% []
🔵 be/src/runtime/exec_env.cpp 4 4 100.00% []
🔵 be/src/common/daemon.cpp 45 45 100.00% []

@murphyatwork murphyatwork changed the title [Enhancement] add jemalloc metadata tracker [Enhancement] add jemalloc memory tracker Sep 25, 2024
@murphyatwork murphyatwork merged commit 2b4bced into StarRocks:main Sep 26, 2024
71 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 26, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 26, 2024
Copy link
Contributor

mergify bot commented Sep 26, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 26, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2b4bced)
mergify bot pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2b4bced)
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants