-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] default current_timestamp broken after update to 3.3.2 from 3.2.10 #50911
Merged
meegoo
merged 3 commits into
StarRocks:main
from
rohitrs1983:default_current_timestamp_fix
Sep 20, 2024
Merged
[BugFix] default current_timestamp broken after update to 3.3.2 from 3.2.10 #50911
meegoo
merged 3 commits into
StarRocks:main
from
rohitrs1983:default_current_timestamp_fix
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Satardekar <[email protected]>
decster
approved these changes
Sep 12, 2024
sevev
approved these changes
Sep 13, 2024
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
meegoo
approved these changes
Sep 20, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
…3.2.10 (#50911) Signed-off-by: Rohit Satardekar <[email protected]> (cherry picked from commit 3f73bd0)
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
…3.2.10 (#50911) Signed-off-by: Rohit Satardekar <[email protected]> (cherry picked from commit 3f73bd0) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…3.2.10 (backport #50911) (#51182) Co-authored-by: Rohit Satardekar <[email protected]>
ignore backport to branch-3.2, not an issue on branch-3.2 |
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…3.2.10 (StarRocks#50911) Signed-off-by: Rohit Satardekar <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
default current_timestamp broken after update to 3.3.2 from 3.2.10
What I'm doing:
mysql> CREATE TABLE
migrations
(version_id
bigint(20) NOT NULL COMMENT "",id
bigint(20) NOT NULL AUTO_INCREMENT COMMENT "",is_applied
boolean NOT NULL COMMENT "",tstamp
datetime NULL DEFAULT CURRENT_TIMESTAMP COMMENT "" ) ENGINE=OLAP PRIMARY KEY(version_id
,id
) DISTRIBUTED BY HASH(id
) ORDER BY(version_id
) PROPERTIES("replication_num" = "1");Query OK, 0 rows affected (0.04 sec)
mysql> insert into migrations (version_id, is_applied) values (0, true);
Query OK, 1 row affected (0.39 sec)
{'label':'insert_2c42bf7a-6f3b-11ef-afc1-024253f5d68c', 'status':'VISIBLE', 'txnId':'2093'}
mysql> select * from migrations;
+------------+------+------------+---------------------+
| version_id | id | is_applied | tstamp |
+------------+------+------------+---------------------+
| 0 | 1 | 1 | 2024-09-10 11:39:00 |
+------------+------+------------+---------------------+
1 row in set (0.03 sec)
Fixes #50872
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: