Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] default current_timestamp broken after update to 3.3.2 from 3.2.10 #50911

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented Sep 10, 2024

Why I'm doing:

default current_timestamp broken after update to 3.3.2 from 3.2.10

What I'm doing:

mysql> CREATE TABLE migrations ( version_id bigint(20) NOT NULL COMMENT "", id bigint(20) NOT NULL AUTO_INCREMENT COMMENT "", is_applied boolean NOT NULL COMMENT "", tstamp datetime NULL DEFAULT CURRENT_TIMESTAMP COMMENT "" ) ENGINE=OLAP PRIMARY KEY(version_id, id) DISTRIBUTED BY HASH(id) ORDER BY(version_id) PROPERTIES("replication_num" = "1");
Query OK, 0 rows affected (0.04 sec)

mysql> insert into migrations (version_id, is_applied) values (0, true);
Query OK, 1 row affected (0.39 sec)
{'label':'insert_2c42bf7a-6f3b-11ef-afc1-024253f5d68c', 'status':'VISIBLE', 'txnId':'2093'}

mysql> select * from migrations;
+------------+------+------------+---------------------+
| version_id | id | is_applied | tstamp |
+------------+------+------------+---------------------+
| 0 | 1 | 1 | 2024-09-10 11:39:00 |
+------------+------+------------+---------------------+
1 row in set (0.03 sec)

Fixes #50872

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/InsertPlanner.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo merged commit 3f73bd0 into StarRocks:main Sep 20, 2024
43 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 20, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
…3.2.10 (#50911)

Signed-off-by: Rohit Satardekar <[email protected]>
(cherry picked from commit 3f73bd0)
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
…3.2.10 (#50911)

Signed-off-by: Rohit Satardekar <[email protected]>
(cherry picked from commit 3f73bd0)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@kevincai
Copy link
Contributor

ignore backport to branch-3.2, not an issue on branch-3.2

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default current_timestamp broken after update to 3.3.2 from 3.2.10
5 participants