Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix complex type timestamp timezone in parquet scanner #50448

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[BugFix] Fix complex type timestamp timezone in parquet scanner #50448

merged 1 commit into from
Aug 30, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 30, 2024 •
edited
Loading

Why I'm doing:

read timestamp in complex type does not use timezone, and session variable time_zone is not work

What I'm doing:

fix this

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner August 30, 2024 05:06
@github-actions github-actions bot added the 3.3 label Aug 30, 2024
@mergify mergify bot assigned wyb Aug 30, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/parquet_scanner.cpp 4 4 100.00% []

@wyb wyb merged commit 44aa1be into StarRocks:main Aug 30, 2024
59 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 30, 2024
@wyb @mergify
[BugFix] Fix complex type timestamp timezone in parquet scanner (#50448)
cd7d214 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 44aa1be)
@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
@mergify @wyb
[BugFix] Fix complex type timestamp timezone in parquet scanner (back…
b69e91f 
…port #50448) (#50482)

Co-authored-by: wyb <[email protected]>
@wyb
Copy link
Contributor Author

wyb commented Sep 2, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@wyb @mergify
[BugFix] Fix complex type timestamp timezone in parquet scanner (#50448)
4803659 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 44aa1be)
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
@mergify @wyb
[BugFix] Fix complex type timestamp timezone in parquet scanner (back…
3716aa4 
…port #50448) (#50534)

Co-authored-by: wyb <[email protected]>
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
@wyb @va-os-commits
[BugFix] Fix complex type timestamp timezone in parquet scanner (Star…
adf1a6e 
…Rocks#50448)

Signed-off-by: wyb <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@wyb @renzhimin7
[BugFix] Fix complex type timestamp timezone in parquet scanner (Star…
520a360 
…Rocks#50448)

Signed-off-by: wyb <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@meegoo meegoo meegoo approved these changes

Assignees

@wyb wyb

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyb @meegoo @Seaven