[Enhancement] Delete garbage data throught recycle bin after truncate table in share data mode #49975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincai
reviewed
Aug 20, 2024
Comment on lines
163
to
166
| try { | ||
| GlobalStateMgr.getCurrentState().getRecycleBin().erasePartition(Long.MAX_VALUE); | ||
| } catch (Exception ignore) { | ||
| } |
There was a problem hiding this comment.
Suggested change
| try { | |
| GlobalStateMgr.getCurrentState().getRecycleBin().erasePartition(Long.MAX_VALUE); | |
| } catch (Exception ignore) { | |
| } | |
| ExceptionChecker.expectThrowsNoException(() -> GlobalStateMgr.getCurrentState().getRecycleBin().erasePartition(Long.MAX_VALUE); |
| @@ -902,6 +902,11 @@ protected void runAfterCatalogReady() { | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public synchronized boolean isContainedInidToRecycleTime(long id) { | |||
There was a problem hiding this comment.
Suggested change
| public synchronized boolean isContainedInidToRecycleTime(long id) { | |
| synchronized boolean isContainedInidToRecycleTime(long id) { |
remove the access identifier, so the interface can be accessible from the same package, but not visible outside the package, which can be a workaround to allow UT accessing.
| // For cloud native table, add partition into recycle Bin after truncate table. | ||
| // It is no necessary for share nothing mode because file will be deleted throught | ||
| // tablet report in this case. | ||
| if (this.isCloudNativeTable()) { |
There was a problem hiding this comment.
shall be applicable to shared-data materialized view as well?
Comment on lines
177
to
204
| new Expectations() { | ||
| { | ||
| GlobalStateMgr.getCurrentState().getWarehouseMgr(); | ||
| minTimes = 0; | ||
| result = warehouseManager; | ||
| } | ||
| }; | ||
|
|
||
| new MockUp<GlobalStateMgr>() { | ||
| @Mock | ||
| public StarOSAgent getStarOSAgent() { | ||
| return starOSAgent; | ||
| } | ||
| }; | ||
|
|
||
| new MockUp<StarOSAgent>() { | ||
| @Mock | ||
| public ShardInfo getShardInfo(long shardId, long workerGroupId) throws StarClientException { | ||
| return shardInfo; | ||
| } | ||
| }; | ||
|
|
||
| new MockUp<WarehouseManager>() { | ||
| @Mock | ||
| public Warehouse getBackgroundWarehouse() { | ||
| return new DefaultWarehouse(WarehouseManager.DEFAULT_WAREHOUSE_ID, WarehouseManager.DEFAULT_WAREHOUSE_NAME); | ||
| } | ||
| }; |
There was a problem hiding this comment.
check if possible set these common expectations in a function and call the function to set MockUp/Expectations repeatedly.
… table in share data mode Using recycle bin to delete file after truncate table which is more faster than using StarMgrMetaSyncer Signed-off-by: srlch <[email protected]>
Signed-off-by: srlch <[email protected]>
8280ce1
to
b22047c
Compare
Signed-off-by: srlch <[email protected]>
|
kevincai
approved these changes
Aug 29, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
HangyuanLiu
approved these changes
Aug 29, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
… table in share data mode (#49975) Signed-off-by: srlch <[email protected]> (cherry picked from commit 5c03743)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 6, 2024
… table in share data mode (backport #49975) (#50418) Co-authored-by: srlch <[email protected]>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
Sep 6, 2024
… table in share data mode (backport StarRocks#49975) (StarRocks#50418) Co-authored-by: srlch <[email protected]>
va-os-commits
pushed a commit
to va-os-commits/starrocks
that referenced
this pull request
Sep 10, 2024
… table in share data mode (StarRocks#49975) Signed-off-by: srlch <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
… table in share data mode (StarRocks#49975) Signed-off-by: srlch <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using recycle bin to delete file after truncate table which is more faster than using StarMgrMetaSyncer
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: