[BugFix] Should use AggRewriteInfo.NOT_REWRITE other than throw exception when mv rewrite

[kaijianding]

Why I'm doing:

test_pt in sql like below failed to transform to it's mv

        SELECT
            sum(gmv)
        FROM
           test_pt
        WHERE
           id IN (
                SELECT upper(id)
                FROM
                   test_pt2
                WHERE
                    pt = '2023-03-07'
                group by upper(id)
            )

What I'm doing:

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
Potential null pointer exception if newAggregate is referenced when foundIndex is -1.

You can modify the code like this:

if (foundIndex == -1) {
    logMVRewrite(mvRewriteContext, "no aggregate functions found: " + newAggregate != null ? newAggregate.getChildren() : "null");
    return AggRewriteInfo.NOT_REWRITE;
}

[sonarcloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

[FE Incremental Coverage Report]

❌ fail : 6 / 15 (40.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewPushDownRewriter.java	4	13	30.77%	[359, 360, 384, 385, 386, 408, 409, 417, 418]
🔵	com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java	2	2	100.00%	[]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[LiShuMing]

LGTM

[github-actions]

@Mergifyio backport branch-3.3

[mergify]

backport branch-3.3

✅ Backports have been created

• #49309 [BugFix] Should use AggRewriteInfo.NOT_REWRITE other than throw exception when mv rewrite (backport #49168) has been created for branch branch-3.3