[Enhancement][fe] Add ability to cast ROW and ARRAY datatype for Trino #48976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -1292,6 +1308,9 @@ private Type getGenericDataType(GenericDataType dataType) { | |||
| throw new ParsingException("Unknown type: %s", typeName); | |||
| } else if (typeName.equals("real")) { | |||
| return ScalarType.createType(PrimitiveType.FLOAT); | |||
| } else if (typeName.equals("array")) { | |||
| TypeParameter typeParam = (TypeParameter) dataType.getArguments().get(0); | |||
| return new ArrayType(getType(typeParam.getValue())); | |||
| } else { | |||
| // this contains datetime/date/numeric type | |||
| return ScalarType.createType(typeName); | |||
There was a problem hiding this comment.
The most risky bug in this code is:
Potential ClassCastException due to assuming that the argument for an "array" type is always of type TypeParameter.
You can modify the code like this:
import io.trino.sql.tree.DataTypeParameter;
// ...
// Line 1292-1295
} else if (typeName.equals("array")) {
if (!(dataType.getArguments().get(0) instanceof TypeParameter)) {
throw new ParsingException("Expected a TypeParameter for array type but got: %s", dataType.getArguments().get(0).getClass().getSimpleName());
}
TypeParameter typeParam = (TypeParameter) dataType.getArguments().get(0);
return new ArrayType(getType(typeParam.getValue()));
}Signed-off-by: 🐼 Samrose Ahmed 🐼 <[email protected]>
a004a7a
to
907430b
Compare
Youngwb
approved these changes
Jul 27, 2024
|
alvin-celerdata
approved these changes
Jul 27, 2024
[FE Incremental Coverage Report]✅ pass : 13 / 13 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
#48976) Signed-off-by: 🐼 Samrose Ahmed 🐼 <[email protected]> (cherry picked from commit 722346b)
Merged
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 29, 2024
…o (backport #48976) (#49026) Co-authored-by: Samrose <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
StarRocks#48976) Signed-off-by: 🐼 Samrose Ahmed 🐼 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently cast as row and cast as array not supported for trino dialect.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: