Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add catalog information in FE's query_detail #40894 #45372

Merged
merged 4 commits into from
May 11, 2024

Conversation

happut
Copy link
Contributor

@happut happut commented May 9, 2024

Add catalog information in FE's query_detail @happut
After enabling collect query details using admin set frontend config("enable_collect_query_detail_info"="true") user can get query detail using curl -uroot: https://172.26.81.138:8030/api/query_detail?event_time=<unixtimestamp_value> , the information is like ...."database":"simo","sql":"insert into abc values (1,2),(2,3)","user":"root"....
There is no catalog information. Like "catalog":"defaut_catalog"

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@happut happut force-pushed the add-catalog-with-query-detail branch from 35e90b9 to 6ee1109 Compare May 9, 2024 11:33
Youngwb
Youngwb previously approved these changes May 9, 2024
Copy link

sonarcloud bot commented May 9, 2024

Copy link

github-actions bot commented May 9, 2024

[FE Incremental Coverage Report]

pass : 9 / 11 (81.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/ConnectProcessor.java 2 3 66.67% [322]
🔵 com/starrocks/qe/QueryDetail.java 6 7 85.71% [314]
🔵 com/starrocks/common/util/LogUtil.java 1 1 100.00% []

Copy link

github-actions bot commented May 9, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 13306dc into StarRocks:main May 11, 2024
49 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 11, 2024
Copy link
Contributor

mergify bot commented May 11, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 11, 2024
wanpengfei-git pushed a commit that referenced this pull request May 11, 2024
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants